Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendermime celloutput gap issue(#7760) #7832

Merged

Conversation

ggbhat
Copy link
Member

@ggbhat ggbhat commented Jan 29, 2020

References

#7760

Code changes

Set line height to normal for pre tag for rendermime.

User-facing changes

Before:
image

After:
celfixed

Backwards-incompatible changes

no

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 29, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@telamonian
Copy link
Member

@telamonian telamonian commented Jan 29, 2020

Looks good! I can't really tell from the screenshots you posted: does changing line-height to normal just fix the issue with the gap between the colored blocks, or does it also reduce the actual spacing between the line of output?

@ggbhat
Copy link
Member Author

@ggbhat ggbhat commented Jan 29, 2020

Looks good! I can't really tell from the screenshots you posted: does changing line-height to normal just fix the issue with the gap between the colored blocks, or does it also reduce the actual spacing between the line of output?

Actually it reduces space between line also. But am not sure on what basis the line-height is set to 1.3077 for pre tag.
var(--jp-code-line-height) has value - 1.3077

@github-actions github-actions bot added tag:Design System CSS tag:CSS labels Feb 24, 2020
@saulshanabrook saulshanabrook added this to the 2.1 milestone Mar 20, 2020
Copy link
Member

@saulshanabrook saulshanabrook left a comment

I tested this on firefox and chrome. Before this change, I see the spaces. After it, they are resolved. Does anyone have reservations merging this?

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 20, 2020

Based on the pics, I think it's probably fine, at least to merge and test and see if we have any unintended consequences.

CC @tgeorgeux as well.

@saulshanabrook saulshanabrook merged commit 22bc544 into jupyterlab:master Mar 20, 2020
7 of 10 checks passed
@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Mar 20, 2020

Thanks @ggbhat for fixing this! We can always revert if we hit issues.

@lock lock bot added the status:resolved-locked label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:rendermime status:resolved-locked tag:CSS tag:Design System CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants