Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected jump to last search result when using documentsearch #7835

Merged
merged 2 commits into from Jan 30, 2020

Conversation

marisaaquilina
Copy link
Contributor

@marisaaquilina marisaaquilina commented Jan 29, 2020

References

This is a fix to issue #7476: adding or deleting cells while using documentsearch unexpectedly jumps to the last result of the query.

Code changes

The jumping behavior was originally an intentional feature, but one that contradicts expected behavior of documentsearch. I have removed _restartQuery() and modified functions supporting this feature in notebooksearchprovider.ts.

User-facing changes

This fix allows users to continue working in their current spot after adding or deleting cells while keeping the document search box open. To proceed to the next search result, users can press enter within the search box as expected.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Jan 29, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.0 milestone Jan 30, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 4be1eb1 into jupyterlab:master Jan 30, 2020
8 of 10 checks passed
@gittar
Copy link

@gittar gittar commented Feb 2, 2020

Thank you, Marisa!

@lock lock bot added the status:resolved-locked label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
@krassowski
Copy link
Member

@krassowski krassowski commented Aug 3, 2021

This also fixed #6701, #7308 and #9437.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:documentsearch status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants