Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followup #7767: small bugfix to lookup in UNSTABLE_getReact #7846

Merged
merged 1 commit into from Feb 4, 2020

Conversation

telamonian
Copy link
Member

@telamonian telamonian commented Feb 4, 2020

References

followup to #7767

Small fix to icon lookup routine in LabIcon.UNSTABLE_getReact

Code changes

changed ref to ._instances => ._instancesByNameAndClassName

User-facing changes

N/A

Backwards-incompatible changes

N/A

@blink1073
Copy link
Member

@blink1073 blink1073 commented Feb 4, 2020

Thanks! I'll cut the RC tomorrow morning.

@blink1073 blink1073 merged commit ff5db65 into jupyterlab:master Feb 4, 2020
10 of 11 checks passed
@jasongrout jasongrout added this to the 2.0 milestone Feb 24, 2020
@lock lock bot added the status:resolved-locked label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants