Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add password dialog to apputils #7855

Merged
merged 2 commits into from Feb 24, 2020
Merged

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Feb 6, 2020

Code changes

Adding a password dialog to AppUtil.

This is something that I used for an extension (and required duplicating some JupyterLab code). This is much simpler this way.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Feb 6, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

vidartf
vidartf approved these changes Feb 6, 2020
/**
* Widget body for input password dialog
*/
class InputPasswordDialog extends InputDialogBase<string> {
Copy link
Member

@vidartf vidartf Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to just inherit InputTextDialog ?

Copy link
Member Author

@SylvainCorlay SylvainCorlay Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that it would change the length of the code. The boolean input dialog is also basically the same. All that differ is the constructor.

@jtpio
Copy link
Member

@jtpio jtpio commented Feb 17, 2020

How about adding it to the "User Interface Helpers" docs as well?

https://jupyterlab.readthedocs.io/en/latest/developer/ui_helpers.html#input-dialogs

@SylvainCorlay
Copy link
Member Author

@SylvainCorlay SylvainCorlay commented Feb 19, 2020

How about adding it to the "User Interface Helpers" docs as well?

Just added an example.

@SylvainCorlay
Copy link
Member Author

@SylvainCorlay SylvainCorlay commented Feb 19, 2020

Any chances of getting this in?

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 added this to the 2.0 milestone Feb 24, 2020
@blink1073 blink1073 merged commit 3ba2e65 into jupyterlab:master Feb 24, 2020
8 of 10 checks passed
@SylvainCorlay SylvainCorlay deleted the PasswordDialog branch Feb 27, 2020
@lock lock bot added the status:resolved-locked label Apr 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation pkg:apputils status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants