Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensures that 'shift tab' => dedent shortcut works correctly in the file editor #7865

Merged
merged 1 commit into from Feb 10, 2020

Conversation

telamonian
Copy link
Member

@telamonian telamonian commented Feb 9, 2020

References

fixes #6127
cf #5060

Fixes 'shift tab' behavior in the file editor, makes it the same as in console and notebook.

With the fix, 'shift tab' will behave the following way in these contexts:

  • cursor in leading whitespace on a line
    • dedent line
  • text is selected
    • dedent all lines on which text is selected
  • cursor is within text on a line
    • run the "tooltip:launch-file" command (tries to open a tooltip with a docstring)

Code changes

Made the 'shift tab' shortcut for the "tooltip:launch-file" command appropriately selective (same behavior as for "tooltip:launch-console" and "tooltip:launch-notebook")

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Feb 9, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 7a97756 into jupyterlab:master Feb 10, 2020
10 checks passed
@lock lock bot added the status:resolved-locked label Mar 11, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:tooltip status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants