Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention to IIconRegistry from the docs #7886

Merged
merged 1 commit into from Feb 24, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Feb 15, 2020

References

#7700

Code changes

Documentation only.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Feb 15, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@telamonian telamonian left a comment

LGTM! Now we (by which I mostly mean I) just have to add the LabIcon docs!

@telamonian telamonian added this to the 2.0 milestone Feb 24, 2020
@telamonian telamonian merged commit ad0f1a5 into jupyterlab:master Feb 24, 2020
8 of 10 checks passed
@jtpio jtpio deleted the iconregistry-docs branch Feb 24, 2020
@lock lock bot added the status:resolved-locked label Mar 27, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants