Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle fetch requests in the setting registry's data connector #7927

Merged
merged 4 commits into from Mar 25, 2020

Conversation

ikiw
Copy link
Member

@ikiw ikiw commented Feb 25, 2020

Refactor PR #7879 to use throttler

References

#7879

Code changes

Refactor of older PR #7879, to make use of Throttler in this use case as it solves the purpose of executing the callback only once even though invoked multiple times and making the code more cleaner.

Code change depends on jupyterlab/lumino#54 @afshin

User-facing changes

Backwards-incompatible changes

NO

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Feb 25, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 22, 2020

Dependencies updated.

@ikiw, you'll need to run the following to update dependencies:

jlpm run update:dependency @lumino/polling ^latest
jlpm run update:dependency @lumino/datagrid ^latest

@afshin
Copy link
Member

@afshin afshin commented Mar 23, 2020

@ikiw I rebased against master, updated the Lumino dependencies, and moved the throttling into the setting registry's data connector like we spoke about a few weeks ago on the weekly call. Sorry it took so long!

@afshin
Copy link
Member

@afshin afshin commented Mar 23, 2020

Docs failure is probably related to: jupyterlab/pytest-check-links#7

@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Mar 25, 2020

Tested this in Binder, looks like it properly throttles!

Screen Shot 2020-03-25 at 1 49 02 PM

@saulshanabrook saulshanabrook merged commit 621e43b into jupyterlab:master Mar 25, 2020
45 of 49 checks passed
@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Mar 30, 2020

@meeseeksdev backport to 2.0.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Mar 30, 2020
saulshanabrook added a commit that referenced this issue Mar 30, 2020
…7-on-2.0.x

Backport PR #7927 on branch 2.0.x (Throttle fetch requests in the setting registry's data connector)
saulshanabrook added a commit that referenced this issue Mar 30, 2020
… the setting registry's data connector)"
saulshanabrook added a commit that referenced this issue Mar 30, 2020
…-pr-7927-on-2.0.x

Revert "Backport PR #7927 on branch 2.0.x (Throttle fetch requests in the setting registry's data connector)"
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants