Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IFuture done typings more correct #8032

Merged
merged 1 commit into from Mar 12, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 11, 2020

References

Code changes

The kernel IFuture done promise never returns undefined in practice (since every shell/control message has a reply, which is needed for the done promise to even resolve), so we strengthen the typing in the interface.

This means that things relying on the done resolution do not have to check to see if the value is undefined from a typing perspective.

User-facing changes

Backwards-incompatible changes

The kernel IFuture done promise never returns undefined in practice (since every shell/control message has a reply, which is needed for the done promise to even resolve), so we strengthen the typing in the interface.

This means that things relying on the done resolution do not have to check to see if the value is undefined from a typing perspective.
@jasongrout jasongrout added this to the 2.0 milestone Mar 11, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 11, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

👍

@jasongrout jasongrout merged commit a29398a into jupyterlab:master Mar 12, 2020
10 checks passed
@vidartf
Copy link
Member

@vidartf vidartf commented Mar 12, 2020

(note that strictly speaking this does qualify as backwards incompatible)

@saulshanabrook saulshanabrook removed this from the 2.0 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook removed this from the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook removed this from the 2.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.0.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook removed this from the 2.0.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.0.2 milestone Mar 30, 2020
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:services status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants