Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .yarnrc explicitly in Python setup #8045

Merged
merged 1 commit into from Mar 25, 2020

Conversation

afshin
Copy link
Member

@afshin afshin commented Mar 16, 2020

Code changes

Adds .yarnrc explicitly in Python setup

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 16, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 16, 2020

Do we need a 2.0.2 for this?

@afshin
Copy link
Member Author

@afshin afshin commented Mar 16, 2020

Do we need a 2.0.2 for this?

I think this should be back-ported to 1.2.x and also a patch release for 2.0.x, but as it's not a security consideration, I don't think it's critical how quickly we do it.

@jasongrout jasongrout added the tag:Backport label Mar 16, 2020
@jasongrout jasongrout added this to the 2.0 milestone Mar 20, 2020
@saulshanabrook saulshanabrook removed this from the 2.0 milestone Mar 24, 2020
@saulshanabrook saulshanabrook added this to the 2.0.2 milestone Mar 24, 2020
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 25, 2020

Thanks!

@jasongrout jasongrout merged commit 2ff9683 into jupyterlab:master Mar 25, 2020
18 of 22 checks passed
@jasongrout jasongrout removed this from the 2.0.2 milestone Mar 25, 2020
@jasongrout jasongrout added this to the 2.1 milestone Mar 25, 2020
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 25, 2020

Since this PR will be released in 2.1, I changed the milestone to 2.1. The backport PR would be milestone 2.0 or 2.0.2...

@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 27, 2020

@meeseeksdev backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Mar 27, 2020
meeseeksmachine added a commit to meeseeksmachine/jupyterlab that referenced this issue Mar 27, 2020
…x (Add .yarnrc explicitly in Python setup)
blink1073 pushed a commit that referenced this issue Mar 27, 2020
…5-on-1.2.x

Backport PR #8105 on branch 1.2.x (Backport PR #8045 on branch 1.x (Add .yarnrc explicitly in Python setup))
@saulshanabrook saulshanabrook removed this from the 2.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook removed this from the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.1 milestone Mar 30, 2020
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
@afshin afshin deleted the include-yarnrc branch Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked tag:Backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants