Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cell execution when recording timing #8057

Merged
merged 1 commit into from Mar 24, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 19, 2020

References

Fixes #8056

Code changes

The recordTiming future message hook should always return true.

Returning false prevents the message from being processed by the future or by any other hook, which messes everything up.

User-facing changes

Backwards-incompatible changes

Returning false prevents the message from being processed by the future or by any other hook, which messes everything up.

Fixes jupyterlab#8056
@jasongrout jasongrout added this to the 2.0 milestone Mar 19, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 19, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Mar 19, 2020

This is definitely a 2.0.x bugfix.

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Mar 24, 2020

CC @saulshanabrook - can you review this?

@saulshanabrook saulshanabrook removed this from the 2.0 milestone Mar 24, 2020
@saulshanabrook saulshanabrook added this to the 2.1 milestone Mar 24, 2020
@saulshanabrook saulshanabrook self-requested a review Mar 24, 2020
@saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Mar 24, 2020

Works for me! Thanks @jasongrout and @aquirdTurtle for reporting!

@saulshanabrook saulshanabrook merged commit 3b4a300 into jupyterlab:master Mar 24, 2020
17 of 22 checks passed
@saulshanabrook saulshanabrook removed this from the 2.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook removed this from the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook removed this from the 2.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.0.2 milestone Mar 30, 2020
jasongrout added a commit to jasongrout/jupyterlab-execute-time that referenced this issue Apr 8, 2020
There was a bug in JLab 2.0.0 and 2.0.1 that prevented cell execution when recordTiming was enabled. You might be able to cut down on support issues if you just go ahead and require at least JLab 2.0.2.

See jupyterlab/jupyterlab#8057 and jupyterlab/jupyterlab#8056
mlucool pushed a commit to deshaw/jupyterlab-execute-time that referenced this issue Apr 9, 2020
There was a bug in JLab 2.0.0 and 2.0.1 that prevented cell execution when recordTiming was enabled. You might be able to cut down on support issues if you just go ahead and require at least JLab 2.0.2.

See jupyterlab/jupyterlab#8057 and jupyterlab/jupyterlab#8056
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:cells status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants