Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change header area to a box panel #8059

Merged
merged 1 commit into from Mar 22, 2020
Merged

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 19, 2020

References

Fixes #7279

Code changes

This makes the header area similar to the bottom area, and means header children can set their min-height and the header area will adjust to accommodate it.

User-facing changes

Backwards-incompatible changes

This might be considered a backwards-incompatible change, in that it changes the behavior of the header area. If you previously set the min-height of the header area, that could be overridden now with the min-height of a header child element. On the other hand, if we consider this more of a bugfix, then perhaps we do not consider it backwards incompatible.

This makes it similar to the bottom panel, and means widgets can set their min-height and the header region will adjust to accommodate it.

Fixes jupyterlab#7279
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 19, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Mar 19, 2020

Not sure if this should be a 2.0 or a 3.0 feature. I can see arguments both ways. It does not change code APIs, but does change the behavior of the header area (but makes it better, I think).

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Mar 19, 2020

I'd probably come down on the side of it being okay to put in 2.x rather than waiting until 3.0.

@jasongrout jasongrout added this to the 2.0 milestone Mar 19, 2020
@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Mar 19, 2020

Assigning to 2.0 milestone, but feel free to push to 3.0 if you feel this is backwards incompatible.

@jasongrout jasongrout removed this from the 2.0 milestone Mar 20, 2020
@jasongrout jasongrout added this to the 2.1 milestone Mar 20, 2020
afshin
afshin approved these changes Mar 20, 2020
Copy link
Member

@afshin afshin left a comment

Thanks @jasongrout!

@afshin
Copy link
Member

@afshin afshin commented Mar 20, 2020

I don't think this is backward incompatible, I agree that it should be a 2.x change.

@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 22, 2020

Thanks!

@blink1073 blink1073 merged commit 4b0cf44 into jupyterlab:master Mar 22, 2020
17 of 22 checks passed
@saulshanabrook saulshanabrook removed this from the 2.1 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook removed this from the 2.0.2 milestone Mar 30, 2020
@saulshanabrook saulshanabrook added this to the 2.1 milestone Mar 30, 2020
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:application status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants