Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow replacing with empty strings #8100

Merged
merged 4 commits into from Mar 30, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Mar 27, 2020

References

Fixes #8098

Code changes

Fix boolean logic to allow replacing with empty strings.

User-facing changes

Fix replace button active and hover states:

Screen Shot 2020-03-27 at 6 32 12 AM

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 27, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 2.1 milestone Mar 27, 2020
@github-actions github-actions bot added tag:Design System CSS pkg:documentsearch tag:CSS labels Mar 27, 2020
Copy link
Member

@saulshanabrook saulshanabrook left a comment

This works for a single "replace" but doesn't seem to work for "replace all" which seems like a bug

@jasongrout
Copy link
Contributor Author

@jasongrout jasongrout commented Mar 30, 2020

This works for a single "replace" but doesn't seem to work for "replace all" which seems like a bug

Yep, good catch. Same change was needed in the next function used for replaceAll.

Copy link
Member

@saulshanabrook saulshanabrook left a comment

Works now for me!

@saulshanabrook saulshanabrook merged commit 83cd6c9 into jupyterlab:master Mar 30, 2020
43 of 49 checks passed
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:documentsearch status:resolved-locked tag:CSS tag:Design System CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants