Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for yarn #8104

Merged
merged 1 commit into from Mar 27, 2020
Merged

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 27, 2020

References

Fixes #8102

Code changes

Adds network-timeout config to our .yarnrc file.

User-facing changes

Users can install extensions in environments with slow or proxied internet connections.

Backwards-incompatible changes

None

@blink1073 blink1073 added this to the 2.1 milestone Mar 27, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 27, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

afshin
afshin approved these changes Mar 27, 2020
Copy link
Member

@afshin afshin left a comment

👍
Cheers!

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 27, 2020

Failures are due to known flaky tests, merging.

@blink1073 blink1073 merged commit c4a0f4a into jupyterlab:master Mar 27, 2020
72 of 76 checks passed
@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 27, 2020

@meeseeksdev backport to 1.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Mar 27, 2020
blink1073 pushed a commit that referenced this issue Mar 27, 2020
…4-on-1.2.x

Backport PR #8104 on branch 1.2.x (Increase timeout for yarn)
@echarles
Copy link
Contributor

@echarles echarles commented Mar 28, 2020

I see less failure. This config may be the key to solve flaky CI. Thx again for this @blink1073.

@blink1073 blink1073 deleted the yarn-timeout branch Mar 29, 2020
@saulshanabrook saulshanabrook modified the milestones: 2.1, 2.0.2 Mar 30, 2020
@lock lock bot added the status:resolved-locked label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked tag:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants