Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #7677 #8112

Merged
merged 4 commits into from Mar 28, 2020
Merged

Revert #7677 #8112

merged 4 commits into from Mar 28, 2020

Conversation

afshin
Copy link
Member

@afshin afshin commented Mar 28, 2020

Adds --max-old-space script back to buildutils to support Node v10+

References

Fixes #8083
Reverts #7677

Code changes

Reverts #7677

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 28, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 28, 2020

A package-lock.json snuck in there, whoops!

@blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 28, 2020

Can you please also update our engines spec for node 10+? We should point to this file in CONTRIBUTING.md to keep them in sync and as a reminder of where the value is enforced.

@blink1073 blink1073 added this to the 2.1 milestone Mar 28, 2020
CONTRIBUTING.md Outdated
@@ -69,7 +69,7 @@ You can launch a binder with the latest JupyterLab master to test something (thi

### Installing Node.js and jlpm

Building JupyterLab from its GitHub source code requires Node.js. The development version requires Node.js version 12+.
Building JupyterLab from its GitHub source code requires Node.js. The development version requires Node.js version 10+.
Copy link
Member

@blink1073 blink1073 Mar 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a note that this is defined in dev_mode/package.json:engines? I had to look in commands.py to see how we were enforcing the node version.

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 5977421 into jupyterlab:master Mar 28, 2020
71 of 76 checks passed
@lock lock bot added the status:resolved-locked label May 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants