Revert #7677 #8112
Merged
Revert #7677 #8112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
A |
|
Can you please also update our engines spec for node 10+? We should point to this file in CONTRIBUTING.md to keep them in sync and as a reminder of where the value is enforced. |
blink1073
reviewed
Mar 28, 2020
CONTRIBUTING.md
Outdated
| @@ -69,7 +69,7 @@ You can launch a binder with the latest JupyterLab master to test something (thi | |||
|
|
|||
| ### Installing Node.js and jlpm | |||
|
|
|||
| Building JupyterLab from its GitHub source code requires Node.js. The development version requires Node.js version 12+. | |||
| Building JupyterLab from its GitHub source code requires Node.js. The development version requires Node.js version 10+. | |||
There was a problem hiding this comment.
Can you please add a note that this is defined in dev_mode/package.json:engines? I had to look in commands.py to see how we were enforcing the node version.
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds
--max-old-spacescript back tobuildutilsto support Node v10+References
Fixes #8083
Reverts #7677
Code changes
Reverts #7677
User-facing changes
N/A
Backwards-incompatible changes
N/A