Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix property inspector and widget tracker load behavior #8114

Merged
merged 2 commits into from Mar 28, 2020

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Mar 28, 2020

References

#8113

Code changes

Adds layout restoration for the property inspector and fixes the case where a widget is added to a widget tracker when another widget already has focus. The edge case that this does not address is when an old widget is focused and new widget gets activated but never gets focused. In that case I think it is still fair to call the last focused widget the current one, as the focus tracker does.

The changes to the widget tracker need to be backported to 1.2.x.

User-facing changes

Fixes a user-facing bug where the wrong widget's properties are being inspected.

Backwards-incompatible changes

None.

@blink1073 blink1073 added this to the 2.1 milestone Mar 28, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Mar 28, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member Author

@blink1073 blink1073 commented Mar 28, 2020

ht @tomfaulhaber for noticing the bug.

@blink1073 blink1073 changed the title Fix property inspector and widget tracker load behavior [WIP] Fix property inspector and widget tracker load behavior Mar 28, 2020
@blink1073 blink1073 changed the title [WIP] Fix property inspector and widget tracker load behavior Fix property inspector and widget tracker load behavior Mar 28, 2020
Copy link
Member

@afshin afshin left a comment

Looks good, just one comment.

afshin
afshin approved these changes Mar 28, 2020
@blink1073 blink1073 merged commit 04d2bfa into jupyterlab:master Mar 28, 2020
71 of 76 checks passed
@blink1073 blink1073 deleted the fix-nbtools branch Mar 29, 2020
@lock lock bot added the status:resolved-locked label May 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:application pkg:apputils pkg:property-inspector status:resolved-locked tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants