Fix property inspector and widget tracker load behavior #8114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
ht @tomfaulhaber for noticing the bug. |
blink1073
changed the title
added 2 commits
Mar 28, 2020
blink1073
changed the title
afshin
reviewed
Mar 28, 2020
afshin
approved these changes
Mar 28, 2020
This was referenced Mar 28, 2020
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
References
#8113
Code changes
Adds layout restoration for the property inspector and fixes the case where a widget is added to a widget tracker when another widget already has focus. The edge case that this does not address is when an old widget is focused and new widget gets activated but never gets focused. In that case I think it is still fair to call the last focused widget the current one, as the focus tracker does.
The changes to the widget tracker need to be backported to 1.2.x.
User-facing changes
Fixes a user-facing bug where the wrong widget's properties are being inspected.
Backwards-incompatible changes
None.