Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.x] Set a data attribute for the file type in the file browser #8275

Merged
merged 1 commit into from Apr 24, 2020

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Apr 24, 2020

References

Addresses #8273 for 2.1.x.

Code changes

Adds a data-file-type attribute to a file browser listing item that follows the name of the file type.

User-facing changes

Extension authors can use this to target file browser nodes in CSS, specifically for context menu items.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Apr 24, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.1.x milestone Apr 24, 2020
@blink1073 blink1073 merged commit d6714dc into jupyterlab:2.1.x Apr 24, 2020
37 of 39 checks passed
@saulshanabrook saulshanabrook modified the milestones: 2.1.1, 2.1.2 May 4, 2020
@github-actions github-actions bot added the status:resolved-locked label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:filebrowser status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants