Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll into view after delete #8287

Merged
merged 1 commit into from Apr 27, 2020

Conversation

saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented Apr 27, 2020

References

Fixes #7822

Code changes

Scrolls cell into view after deleting

User-facing changes

Before when you deleted a cell it would not move focus to highlight the newly selected cell. Now it will.

Backwards-incompatible changes

None.

@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Apr 27, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout merged commit 330d1b5 into jupyterlab:master Apr 27, 2020
42 checks passed
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 27, 2020

Tested and works great. Thanks!

@jasongrout jasongrout modified the milestones: 3.0, 2.2 Apr 27, 2020
@jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Apr 27, 2020

@meeseeksdev backport to 2.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue Apr 27, 2020
blink1073 pushed a commit that referenced this issue Apr 28, 2020
…7-on-2.1.x

Backport PR #8287 on branch 2.1.x (Scroll into view after delete)
@saulshanabrook saulshanabrook deleted the focus-delete-cell branch May 1, 2020
@saulshanabrook saulshanabrook modified the milestones: 2.2, 2.1.2 May 4, 2020
@github-actions github-actions bot added the status:resolved-locked label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:notebook status:resolved-locked tag:Design and UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants