Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sidebar icon height #8333

Merged
merged 1 commit into from May 1, 2020
Merged

Conversation

ajbozarth
Copy link
Contributor

@ajbozarth ajbozarth commented Apr 30, 2020

Currently icons in the side bar have no height set. This causes the
icons to use the height in the svg itself. For icons in lab whose
height are hardcoded to 16px this is not an issue, but some extensions
can't edit the height in the svg files and this can cause the icon
height to be very large and cause issues with automated test suites.

References

This issue was first found in jupyterlab/jupyterlab-git#604 and a workaround was found and used in elyra-ai/elyra#463 inspired by discussion on jupyterlab/jupyterlab-git#618

Code changes

This PR sets the height of sidebar icons to auto which removes
any specific height from the svg.

User-facing changes

This PR does not affect any core extensiosn and is solely to better
support external extensions.

Currently icons in the side bar have no height set. This causes the
iconsto use the height in the svg itself. For icons in lab whose
height are hardcoded to 16px this is not an issue, but some extensions
can't edit the height in the svg files and this can cause the icon
height to be very large and cause issues with automated test suites.

This PR sets the `height` of sidebar icons to `auto` which removes
any specific height from the svg.

This PR does not affect any core extensiosn and is solely to better
support extenernal extensions.
@ajbozarth ajbozarth requested a review from telamonian Apr 30, 2020
@jupyterlab-dev-mode
Copy link

@jupyterlab-dev-mode jupyterlab-dev-mode bot commented Apr 30, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 830701e into jupyterlab:master May 1, 2020
39 of 40 checks passed
@blink1073
Copy link
Member

@blink1073 blink1073 commented May 1, 2020

@meeseeksdev please backport to 2.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue May 1, 2020
@blink1073 blink1073 added this to the 2.2 milestone May 1, 2020
blink1073 pushed a commit that referenced this issue May 1, 2020
…3-on-2.1.x

Backport PR #8333 on branch 2.1.x (Set sidebar icon height)
@saulshanabrook saulshanabrook removed this from the 2.2 milestone May 4, 2020
@saulshanabrook saulshanabrook added this to the 2.1.2 milestone May 4, 2020
@ajbozarth ajbozarth deleted the sidebar-icon-height branch Nov 16, 2020
@github-actions github-actions bot added the status:resolved-locked label May 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:ui-components status:resolved-locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants