Add link caching #8354
Merged
Add link caching #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Baseline is 56 minutes. |
|
Hmm, this is failing with |
|
First changelog run took 43m. |
|
Docs build was 13 min without a cache, 11 min with cache. |
request the cache version of pytest-check-links clean up packages Revert "clean up packages" This reverts commit dc193e7. Fix ci script build api docs after link checks cache action must target directory break link check into two build and add hashing Ensure the cache dir exists Install docs requirements consolidate jobs again break changelog into its own job cleanup cache paths and increase test timeout fix timeout-minutes specifier try changing cache name and adding restore-keys try changing cache name and adding restore-keys Clean up cache handling Use matrix.group bump version requirement We weren't actually using a cache... Print the contents of the cache dir change the cache name consolidate to one build remove changelog build update restore-keys
|
Down to 10 min for the combined doc tests, impressive. Are we caching all link checks, or just the troublesome github ones? |
|
We cache all links for 24 hrs. |
Okay, that makes waaay more sense than what I was thinking (that we keep the cache forever). That's a really elegant solution to this very niche, very annoying issue |
This was referenced May 6, 2020
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Partially addresses #8117. Utilizes the new caching options in
pytest-check-links(thanks @bollwyvl!).Docs builds go from >1hr total to a single ~10 minute build with a cache. I increased the time limit to 90 so as our change log grows we have some space when the cache is busted.
Code changes
Changes to CI script and GH Actions workflow
User-facing changes
CI builds will be much faster.
Backwards-incompatible changes
None