Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim dot files in filebrowser #8393

Merged
merged 1 commit into from May 8, 2020

Conversation

quangIO
Copy link
Member

@quangIO quangIO commented May 8, 2020

References

#8257 Adding a visual clue for distinguishing hidden files and folders in the file browser window

Code changes

Very minor. I added a css rule and an attribute to DirListing Item.

User-facing changes

Light theme

Dark theme

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 8, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. pkg:filebrowser tag:CSS For general CSS related issues and pecadilloes labels May 8, 2020
@blink1073
Copy link
Member

blink1073 commented May 8, 2020

Thanks @quangIO, you are on 🔥 with these PRs!

@blink1073
Copy link
Member

blink1073 commented May 8, 2020

cc @tgeorgeux for Design input on contrast.

@blink1073 blink1073 added this to the 2.2 milestone May 8, 2020
@tgeorgeux
Copy link
Contributor

tgeorgeux commented May 8, 2020

It's better than it was before, I'm all for it.

@blink1073 blink1073 merged commit 5af220e into jupyterlab:master May 8, 2020
40 checks passed
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants