Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the link expiry to one week #8402

Merged
merged 1 commit into from May 10, 2020

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented May 10, 2020

References

Follow up to #8354. The one day expiry was too long, leading to initial PR runs with no effective cache. Bumping to one week.

Code changes

Increase expiry of link cache.

User-facing changes

Faster CI.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 10, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073 blink1073 added this to the 2.2 milestone May 10, 2020
@blink1073 blink1073 merged commit 6d5240d into jupyterlab:master May 10, 2020
40 checks passed
@blink1073
Copy link
Member Author

blink1073 commented May 10, 2020

@meeseeksdev please backport to 1.2.x

@blink1073
Copy link
Member Author

blink1073 commented May 10, 2020

@meeseeksdev please backport to 2.1.x

@meeseeksdev
Copy link

meeseeksdev bot commented May 10, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout 2.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 6d5240dda71fb3d12814e8b88b09e94e23d42875
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #8402: Increase the link expiry to one week'
  1. Push to a named branch :
git push YOURFORK 2.1.x:auto-backport-of-pr-8402-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #8402 on branch 2.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

blink1073 pushed a commit that referenced this issue May 10, 2020
…2-on-1.2.x

Backport PR #8402 on branch 1.2.x (Increase the link expiry to one week)
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant