Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify that we recomend typescript over JS for extensions #8411

Merged
merged 5 commits into from May 16, 2020

Conversation

saulshanabrook
Copy link
Member

@saulshanabrook saulshanabrook commented May 11, 2020

While it's true that you can write extension in JS, most/all public ones are written in Typescript. So socially you really have to write them in typescript to feel at home. We should make that explicit and be honest about that.

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 11, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@saulshanabrook saulshanabrook changed the title Specify that we reccomend typescript over JS for extensions Specify that we recomend typescript over JS for extensions May 11, 2020
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
@blink1073 blink1073 added this to the 2.2 milestone May 11, 2020
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
@blink1073
Copy link
Member

blink1073 commented May 16, 2020

I'm addressing the CI failures in #8433.

@blink1073 blink1073 merged commit 404330d into master May 16, 2020
78 of 81 checks passed
@vidartf vidartf deleted the saulshanabrook-patch-1 branch May 22, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants