Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default return #8430

Merged
merged 1 commit into from May 16, 2020
Merged

Change default return #8430

merged 1 commit into from May 16, 2020

Conversation

jseabold
Copy link
Contributor

@jseabold jseabold commented May 15, 2020

References

#8429

Code changes

Use the default type expected below.

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 15, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks @jseabold! The CI failures are unrelated.

@blink1073 blink1073 merged commit a0d1dc7 into jupyterlab:master May 16, 2020
38 of 40 checks passed
@blink1073
Copy link
Member

blink1073 commented May 16, 2020

Congrats on your first contribution to JupyterLab 🎉!

@blink1073
Copy link
Member

blink1073 commented May 16, 2020

@meeseeksdevbot please backport to 2.1.x

@blink1073 blink1073 added this to the 2.2 milestone May 16, 2020
@blink1073
Copy link
Member

blink1073 commented May 16, 2020

@meeseeksdev please backport to 2.1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this issue May 16, 2020
blink1073 pushed a commit that referenced this issue May 16, 2020
…0-on-2.1.x

Backport PR #8430 on branch 2.1.x (Change default return)
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants