Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding memory usage warning with nbresuse #8437

Merged
merged 3 commits into from May 18, 2020
Merged

Adding memory usage warning with nbresuse #8437

merged 3 commits into from May 18, 2020

Conversation

Gsbreddy
Copy link
Member

@Gsbreddy Gsbreddy commented May 18, 2020

This PR will address the issue Adding memory usage warning with nbresuse #8280

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 18, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@blink1073
Copy link
Member

blink1073 commented May 18, 2020

Hi @Gsbreddy, thanks for making your first contribution! It looks like the linter isn't happy, can you please run jlpm run lint locally and push those changes? Also, can you please include a screenshot showing the style change?

@blink1073 blink1073 added this to the 2.2 milestone May 18, 2020
@Gsbreddy
Copy link
Member Author

Gsbreddy commented May 18, 2020

Sure thing.

@Gsbreddy
Copy link
Member Author

Gsbreddy commented May 18, 2020

Hey @blink1073 , I checked the lint and pushed the changes.

@blink1073
Copy link
Member

blink1073 commented May 18, 2020

Thanks! Can you please also include a screenshot of the statusbar showing the warning style? You can trigger high memory usage in ipykernel with something like a = [1] * (10 ** 6).

@Gsbreddy
Copy link
Member Author

Gsbreddy commented May 18, 2020

@blink1073 Here you go.
image

Copy link
Member

@blink1073 blink1073 left a comment

Looks great, thank you!

@blink1073 blink1073 merged commit 4fe4dcf into jupyterlab:master May 18, 2020
38 of 40 checks passed
@meeseeksmachine
Copy link
Contributor

meeseeksmachine commented May 21, 2020

This pull request has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/nbresuse-seeking-new-maintainers/2530/11

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:statusbar status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants