Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Python 3.10 compatibility #8445

Merged
merged 1 commit into from May 20, 2020

Conversation

tacaswell
Copy link
Contributor

@tacaswell tacaswell commented May 20, 2020

Don't use string comparison for checking versions now that we have 3.10

References

I have skipped opening an issue as there is not any design decisions
to make here. The current jupyterlab master branch will not install
with cpython master branch due to identifying the version of python as
being too low.

Code changes

  • remove a string-based comparison helper function
  • adds a tuple-based version check directly to setup.py to catch old
    pip versions

User-facing changes

  • None

Backwards-incompatible changes

  • None

Don't use string comparison for checking versions now that we have 3.10
@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 20, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Contributor

@jasongrout jasongrout left a comment

Thank you!

@jasongrout jasongrout merged commit 8325621 into jupyterlab:master May 20, 2020
40 checks passed
@jasongrout jasongrout added this to the 3.0 milestone May 20, 2020
@jasongrout
Copy link
Contributor

jasongrout commented May 20, 2020

@meeseeksdev backport to 2.x

@meeseeksdev
Copy link

meeseeksdev bot commented May 20, 2020

Something went wrong ... Please have a look at my logs.

It seem that the branch you are trying to backport to does not exists.

@tacaswell tacaswell deleted the mnt_fixpy310_compat branch May 20, 2020
@jasongrout
Copy link
Contributor

jasongrout commented May 20, 2020

@meeseeksdev backport to 2.1.x

@tacaswell
Copy link
Contributor Author

tacaswell commented May 20, 2020

Thanks for the quick merge (merged faster than it took my system to finish building the full scipy stack)!

@jasongrout
Copy link
Contributor

jasongrout commented May 20, 2020

Thanks for the quick merge (merged faster than it took my system to finish building the full scipy stack)!

Our tests finished, it looked good, and it seemed pretty cut-and-dry, like you said.

blink1073 pushed a commit that referenced this issue May 21, 2020
…5-on-2.1.x

Backport PR #8445 on branch 2.1.x (MNT: Python 3.10 compatibility)
@saulshanabrook saulshanabrook modified the milestones: 3.0, 2.2 Jun 24, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants