Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors in dependency graph script #8451

Merged
merged 2 commits into from May 21, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented May 20, 2020

References

Code changes

We've been having lots of lint problems noted in this dependency script. This overhauled that code, then generated a new dependency graph (the old one was out of date).

User-facing changes

New dependency graph in docs.

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 20, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 3.0 milestone May 20, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 28fffbd into jupyterlab:master May 21, 2020
38 of 40 checks passed
@saulshanabrook saulshanabrook modified the milestones: 3.0, 2.2 Jun 24, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants