Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on private NPM registry usage #8455

Merged
merged 2 commits into from May 21, 2020
Merged

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented May 21, 2020

References

Improve documentation in light of all questions in #7827.

Fixes #7827
Fixes #7660

Code changes

None

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 21, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@nscozzaro
Copy link
Contributor

nscozzaro commented May 21, 2020

Thank you very much @fcollonval for adding these instructions. One common use case that would be great to include in the documentation would be how to set this globally when running a JupyterHub. If using a docker spawner would the idea be to add this npm set registry to the single-user image? An example of that would also be really useful to me, and probably a lot of other people as well, e.g. #7660

@fcollonval
Copy link
Member Author

fcollonval commented May 21, 2020

If using a docker spawner would the idea be to add this npm set registry to the single-user image?

Yes, the important point to have in mind is that the registry needs to be set on the machine (virtual or not) on which JupyterLab is built. So if JupyterLab is built as part of the docker construction or if you want users to be able to install extension, then yes the registry needs to be set.

⚠️ You should set the registry for both npm and yarn

An example of that would also be really useful to me, and probably a lot of other people as well

As much as I understand the request, there is no way I can display information about my company infrastructure. Moreover this is totally unrelated to JupyterLab itself and purely a question of IT infrastructure and npm/yarn configuration (meaning there is no good example for the many).

Copy link
Member

@blink1073 blink1073 left a comment

Thanks @fcollonval!

@blink1073 blink1073 merged commit 3892e59 into master May 21, 2020
77 of 80 checks passed
@blink1073 blink1073 added this to the 2.2 milestone May 21, 2020
@vidartf vidartf deleted the fcollonval-patch-1 branch May 22, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
3 participants