Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to react example in extension-examples repo #8474

Merged
merged 1 commit into from May 26, 2020
Merged

Add link to react example in extension-examples repo #8474

merged 1 commit into from May 26, 2020

Conversation

yuvipanda
Copy link
Contributor

@yuvipanda yuvipanda commented May 26, 2020

References

Spotted when filing #8473

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 26, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@@ -46,6 +46,9 @@ The `running component <https://github.com/jupyterlab/jupyterlab/blob/f2e0cde0e7
and the ``createSearchOverlay`` function in the `search overlay <https://github.com/jupyterlab/jupyterlab/blob/f2e0cde0e7c960dc82fd9b010fcd3dbd9e9b43d0/packages/documentsearch/src/searchoverlay.tsx#L440-L457>`__
use both of these features and serve as a good reference for best practices.

There is also a `simple example <https://github.com/jupyterlab/extension-examples/tree/71486d7b891175fb3883a8b136b8edd2cd560385/react/react-widget>`_ making
a Lumino react widget in the JupyterLab `extension examples repository <https://github.com/jupyterlab/extension-examples>`_.
Copy link
Member

@jtpio jtpio May 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks the same on the page:

Suggested change
a Lumino react widget in the JupyterLab `extension examples repository <https://github.com/jupyterlab/extension-examples>`_.
a Lumino React widget in the JupyterLab `extension examples repository <https://github.com/jupyterlab/extension-examples>`_.

jtpio
jtpio approved these changes May 26, 2020
Copy link
Member

@jtpio jtpio left a comment

Thanks!

@blink1073 blink1073 merged commit 4f8b46d into jupyterlab:master May 26, 2020
37 of 40 checks passed
@blink1073 blink1073 added this to the 2.2 milestone May 26, 2020
@yuvipanda yuvipanda deleted the doc/react branch May 27, 2020
saulshanabrook pushed a commit that referenced this issue Jun 25, 2020
Add link to react example in extension-examples repo
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants