Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text-based image viewer for SVG, fix token doc #8495

Merged
merged 1 commit into from May 30, 2020

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented May 29, 2020

References

Code changes

  • adds an Image (Text) factory
  • defaults SVG to use it, so that you can see live changes to the svg when it renders
  • fixes token docs

User-facing changes

  • None, in particular, other than an additional (default) option for opening svg

Screenshot from 2020-05-28 23-34-04

Backwards-incompatible changes

Might break xbm, but then maybe it's not that useful anyway. I could dig up any other text-based formats that browsers generally support natively (without some library).

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented May 29, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Nice, thanks!

@blink1073 blink1073 added this to the 2.2 milestone May 30, 2020
@blink1073 blink1073 merged commit 8525c40 into jupyterlab:master May 30, 2020
38 of 39 checks passed
saulshanabrook pushed a commit that referenced this issue Jun 25, 2020
Add text-based image viewer for SVG, fix token doc
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:imageviewer status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants