Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load CodeMirror theme stylesheets. #8506

Merged
merged 1 commit into from Jun 3, 2020

Conversation

AlbertHilb
Copy link
Member

@AlbertHilb AlbertHilb commented Jun 2, 2020

For the motivations, see my comment on issue #4292.

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented Jun 2, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. tag:CSS For general CSS related issues and pecadilloes labels Jun 2, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Nice, thanks!

@blink1073 blink1073 added this to the 2.2 milestone Jun 3, 2020
@blink1073 blink1073 merged commit c99d1c2 into jupyterlab:master Jun 3, 2020
39 checks passed
@AlbertHilb AlbertHilb deleted the LazyLoadCSS branch Jun 3, 2020
saulshanabrook pushed a commit that referenced this issue Jun 25, 2020
Lazy load CodeMirror theme stylesheets.
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. tag:Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants