Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve whitelist figure description in documentation #8517

Merged
merged 1 commit into from Jun 17, 2020

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jun 4, 2020

The whitelist figure description does not seem to make sense to me. If the extension is whitelisted it should not be removed. It seems to have been copy-pasted from the blacklisted figure description and not adjusted afterwards. Not a native speaker, so may not sound great, just initiating the conversation on this minor point - please feel to propose a better wording.

References

None

Code changes

None

User-facing changes

Before
Screenshot from 2020-06-04 21-31-31

After
Screenshot from 2020-06-04 21-32-24

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented Jun 4, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor

jasongrout commented Jun 4, 2020

Thanks! I think it is clearer with your change as well.

@blink1073 blink1073 merged commit 732de5f into master Jun 17, 2020
78 checks passed
@vidartf vidartf deleted the krassowski-patch-1 branch Jun 18, 2020
@saulshanabrook saulshanabrook added this to the 2.2 milestone Jun 23, 2020
saulshanabrook pushed a commit that referenced this issue Jun 25, 2020
Improve whitelist figure description in documentation
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation pkg:extensionmanager status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants