Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified multicursor backspace code #8523

Merged
merged 1 commit into from Jun 7, 2020

Conversation

benthayer
Copy link
Member

@benthayer benthayer commented Jun 6, 2020

Hi guys,

I was working on jupyter/notebook#5516 and realized there is a simpler implementation of #7401.

This change doesn't fix any issues, but it uses a codemirror library rather than a custom implementation, simplifying the code and probably making it more robust.

This is currently based on master, but I can rebase if you need me to

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented Jun 6, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Nice, thanks!

@blink1073 blink1073 added this to the 2.2 milestone Jun 7, 2020
@blink1073 blink1073 merged commit b1e2b83 into jupyterlab:master Jun 7, 2020
39 checks passed
saulshanabrook pushed a commit that referenced this issue Jun 25, 2020
Simplified multicursor backspace code
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:codemirror status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants