New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ToC Extension into core #8538
Conversation
added new features to toc
in the application.
Make toolbar button sizing and styling more consistent with other items in the application.
Check if tags are actually an array, and simplify tag list creation.
Sanitize html before dangerously setting it.
Markdown parsing
Update demo gif.
Remove react duplication in JLab 0.34
Fixed the remaining lint errors - I had to use unsafe react methods (such as I also changed the version of |
Just checking - did you change the collapsing functionality already to a signal or something, or is that something we'll need to do in another PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the assumption that the follow issues will be opened and dealt with in follow up PRs:
- Update icon usage to LabIcon, this includes moving the svgs into ui-components
- Write tests
- Update Docs to include toc
- Open issues for any other things raised in jupyterlab/team-compass#63 or in key issues on the toc repo
@jasongrout No I didn't include the collapsing signal in this PR (it's currently a setting that makes the collapsing disabled by default). |
I opened #8546 for tracking. |
The usage test is hanging again, merging. Thanks @marthacryan! This is an epic first contribution |
@blink1073 Thank you! |
Merge ToC Extension into core
References
As discussed in this issue and in the weekly dev meetings, the ToC extension seems to have enough support to be merged into jupyterlab core.
Code changes
To follow the conventions of other core packages, the ToC extension is split into a
toc
package and atoc-extension
package. There are a few changes to the configurations and imports to follow conventions for packages / make the extension work in core. Otherwise it's importing the toc code "as-is" at the moment.User-facing changes
This will cause the ToC extension to appear as an option in the left side panel along with the File Browser, Running Terminals and Kernels, etc.