Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typo in getting started docs, proxy #8549

Merged
merged 1 commit into from Jun 17, 2020

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Jun 12, 2020

References

Code changes

User-facing changes

It's just a small typo, an extra space in proxy.comp any.com, in the install guide, in the section about proxies.

From:

set HTTPS_PROXY=https://USER:PWD@proxy.comp any.com:PORT

To:

set HTTPS_PROXY=https://USER:PWD@proxy.company.com:PORT

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented Jun 12, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Contributor

@jasongrout jasongrout left a comment

Thanks!

@jasongrout jasongrout added this to the 3.0 milestone Jun 12, 2020
@jasongrout jasongrout added the tag:Backport This PR is slated to be backported after it is merged. label Jun 12, 2020
@blink1073 blink1073 merged commit db7ee8d into jupyterlab:master Jun 17, 2020
39 checks passed
@tiangolo tiangolo deleted the patch-1 branch Jun 17, 2020
@saulshanabrook saulshanabrook modified the milestones: 3.0, 2.2 Jun 24, 2020
saulshanabrook pushed a commit that referenced this issue Jun 25, 2020
 Fix small typo in getting started docs, proxy
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Backport This PR is slated to be backported after it is merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants