Support macOptionIsMeta option in terminal#8573
Merged
blink1073 merged 2 commits intojupyterlab:masterfrom Jun 17, 2020
Merged
Conversation
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
blink1073
reviewed
Jun 16, 2020
Contributor
blink1073
left a comment
blink1073
left a comment
There was a problem hiding this comment.
Thanks for this! I just had one nit.
Contributor
Author
|
I would appreciate if someone fix my lame English wordings. |
Contributor
|
@atsuoishimoto your English is quite good! Thank you so much and congratulations on your first contribution to JupyterLab! |
Contributor
Author
|
Thank you! |
saulshanabrook
pushed a commit
that referenced
this pull request
Jun 25, 2020
Support macOptionIsMeta option in terminal
github-actions
bot
added
the
status:resolved-locked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Closes #4236 (Terminal option/alt as meta key? ).
Code changes
Add new option to terminal config.
User-facing changes
Allow macOS users to use standard key binding such as option+f.
Backwards-incompatible changes
None