Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support macOptionIsMeta option in terminal #8573

Merged
merged 2 commits into from Jun 17, 2020

Conversation

atsuoishimoto
Copy link
Contributor

@atsuoishimoto atsuoishimoto commented Jun 16, 2020

References

Closes #4236 (Terminal option/alt as meta key? ).

Code changes

Add new option to terminal config.

User-facing changes

Allow macOS users to use standard key binding such as option+f.

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

jupyterlab-dev-mode bot commented Jun 16, 2020

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@blink1073 blink1073 left a comment

Thanks for this! I just had one nit.

packages/terminal/src/tokens.ts Outdated Show resolved Hide resolved
@blink1073 blink1073 added this to the 3.0 milestone Jun 16, 2020
@atsuoishimoto
Copy link
Contributor Author

atsuoishimoto commented Jun 16, 2020

I would appreciate if someone fix my lame English wordings.

Copy link
Member

@blink1073 blink1073 left a comment

Thanks!

@blink1073 blink1073 merged commit 5ccc6e1 into jupyterlab:master Jun 17, 2020
@blink1073
Copy link
Member

blink1073 commented Jun 17, 2020

@atsuoishimoto your English is quite good! Thank you so much and congratulations on your first contribution to JupyterLab!

@atsuoishimoto
Copy link
Contributor Author

atsuoishimoto commented Jun 17, 2020

Thank you!

saulshanabrook pushed a commit that referenced this pull request Jun 25, 2020
Support macOptionIsMeta option in terminal
@jasongrout jasongrout modified the milestones: 3.0, 2.2 Nov 12, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:terminal status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal option/alt as meta key?
3 participants