Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cur extension for url-loader #8634

Merged
merged 1 commit into from Jul 1, 2020

Conversation

yitzchak
Copy link
Member

References

https://developer.mozilla.org/en-US/docs/Web/CSS/cursor

Code changes

CSS cursor attribute allows multiple files as fallbacks including Windows cursors (.cur), PNG, etc. Some packages in npm come packaged with .cur files and therefore will fail in webpack during installation.

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@telamonian
Copy link
Member

Though I for one have never seen a .cur file, this does appear to be kosher. I'll pull this in, unless anyone has objections.

@yitzchak Out of curiosity, what's an example of a package that will cause webpack to fail without a cur loader?

@yitzchak
Copy link
Member Author

@telamonian Thanks! The package that I currently have the issue with is kekule. Working on a widget version.

@telamonian telamonian merged commit 750771e into jupyterlab:master Jul 1, 2020
@blink1073
Copy link
Member

Congratulations on your first contribution to JupyterLab @yitzchak!

@yitzchak yitzchak deleted the add-cur-loader branch July 1, 2020 21:57
@yitzchak
Copy link
Member Author

yitzchak commented Jul 1, 2020

Thanks @blink1073!

@blink1073 blink1073 added this to the 3.0 milestone Sep 11, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants