Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for the ToC #8757

Merged
merged 7 commits into from Aug 3, 2020
Merged

Add tests for the ToC #8757

merged 7 commits into from Aug 3, 2020

Conversation

marthacryan
Copy link
Member

Fixes #8558. Adds standard jest tests for the Table of Contents.
Tests for these things:

  • Creates a TableOfContents widget
  • Tests the following for all generators (notebook, markdown, markdown viewer, latex, python)
    • Create generator
    • Add generator to the TableOfContentsRegistry
    • Find the generator (given a DocumentWidget)
    • Change the current widget of the TableOfContents

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@marthacryan marthacryan marked this pull request as draft August 3, 2020 18:56
@marthacryan marthacryan marked this pull request as ready for review August 3, 2020 19:02
@blink1073 blink1073 added this to the 3.0 milestone Aug 3, 2020
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit aa92af6 into jupyterlab:master Aug 3, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:toc status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests to ToC
2 participants