PR: Change optionsMap to a an array of tuples to be able to localize the options #8820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
goanpeca
force-pushed
the
update-option-map
branch
from
dd35620
to
ef7c7bd
Compare
goanpeca
force-pushed
the
update-option-map
branch
from
ef7c7bd
to
fc0a7af
Compare
goanpeca
commented
Aug 12, 2020
blink1073
reviewed
Aug 12, 2020
blink1073
reviewed
Aug 12, 2020
blink1073
reviewed
Aug 12, 2020
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
References
Code changes
NotebookTools.KeySelector.IOptionsThe
optionsMapused in theKeySelectorof thenotebooktoolshas been renamed and restructured as an array of tuples, instead of an object.These options are now localizable:
User-facing changes
The export as options on the
Filemenu has been shortened to avoid redundancy. The text in the palette has changed fromExport Notebook to {something}toExport Notebook: {something}, which makes translations work as it is not a full sentence but two parts that are translated independently. (that is why we need to make a harder sentence split with the:)Before
After
Backwards-incompatible changes
OptionsMap that use the localizable string as the key. The names of these var will be changed to break (and force) the correct usage.
KeySelector.IOptions.titleis no longer optional. We should encourage devs to give displayable/localizable names.KeySelector.IOptions.optionsMap->KeySelector.IOptions.optionValueArray