Adding a mime extension to the webpack config

[mnowacki-b]

References

Adds to: #7468

Code changes

• We making it possible for package to include normal and mime extension
• We are moving script loading path logic from server to front end

TODO

• Introduce new css exposed endpoint for the extension style
• Rework how extensions are loaded so each remote entry is loaded once, then the module promises are constructed
• Port example app changes to https://github.com/jupyterlab/jupyterlab/blob/master/dev_mode/index.js

[jupyterlab-dev-mode]

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link:

[mnowacki-b]

@jasongrout
The styles are fixed now!

[jasongrout]

The styles are fixed now!

Excellent! Looks great!

I made one comment about how to use the promises.

[mnowacki-b]

@jasongrout
Thank you for the feedback!
I made the recommended changes, please take a look.
Thanks!

[jasongrout]

@mnowacki-b - I extended the error handling so that an error in loading a single module would not halt the application, using the new Promise.allSettled function. What do you think of my latest commit?

[mnowacki-b]

@jasongrout
Yeah, I think it looks much better now with Promise.allSettled
👍

[jasongrout]

Thanks, and thanks for the cleanup. Do you want to port these changes over to the main application js file at https://github.com/jupyterlab/jupyterlab/blob/master/dev_mode/index.js ?

[mnowacki-b]

Sure will do

[mnowacki-b]

I tested the dev_mod changes by rebuilding the app and running jupyter lab --dev-mode

Everything seems to run fine but I do see the following warnings :

main.ecdd33cd71a3a37854c5.js:372 Unsatisfied version 16.9.0 of shared singleton module react (required ^15.5.4)
getSingletonVersion @ main.ecdd33cd71a3a37854c5.js:372

31packages_settingregistry_lib_index_js.589d5d2e20e120661a9a.js:438 Ignored setting registry preload errors. TypeError: Cannot read property 'jupyter.lab.transform' of undefined
    at SettingRegistry._transform (packages_settingregistry_lib_index_js.589d5d2e20e120661a9a.js:481)
    at packages_settingregistry_lib_index_js.589d5d2e20e120661a9a.js:434
    at Array.map ()
    at SettingRegistry._preload (packages_settingregistry_lib_index_js.589d5d2e20e120661a9a.js:431)
    at new SettingRegistry (packages_settingregistry_lib_index_js.589d5d2e20e120661a9a.js:228)
    at activate (static_index_out_js-webpack_sharing_consume_default_react_react-webpack_sharing_consume_defau-85274a.c122a23c4e684be96cc4.js:4916)

[blink1073]

31packages_settingregistry_lib_index_js.589d5d2e20e120661a9a.js:438 Ignored setting registry preload errors. TypeError: Cannot read property 'jupyter.lab.transform' of undefined

This is being tracked in jupyterlab/jupyterlab_server#113

[blink1073]

Usage test is failing on: python -m jupyterlab.browser_check --core-mode with a timeout: TimeoutError: waiting for selector "#browserTest" failed: timeout 100000ms exceeded

[jasongrout]

The code changes look good to me. Thanks!

[jasongrout]

Probably --core-mode doesn't work right now, we'll need to make a release to update the core shipped js.

[jasongrout]

Yep, the error is because we changed the PageConfig metadata, and the --core-mode is expecting the old version. We'll need a release to fix core mode.

[jasongrout]

Thanks @mnowacki-b!

[blink1073]

Sweet! Thanks @mnowacki-b and @jasongrout!

[mnowacki-b]

Thank you @jasongrout & @blink1073