Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split buildutils into buildutils and builder #8863

Merged
merged 5 commits into from Aug 20, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 20, 2020

References

Fixes #8857

Code changes

The new builder package is used to build extensions. The buildutils now contains repo-specific utilities.

User-facing changes

Cleaner package for building and less dependencies consumed for people wanting to use our build utilities like update:dependency.

Backwards-incompatible changes

Moves build out of buildutils and into builder.

@jasongrout jasongrout added this to the 3.0 milestone Aug 20, 2020
@jasongrout jasongrout added this to In progress in Extension System rework via automation Aug 20, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout
Copy link
Contributor Author

@blink1073 - here is at least a start at splitting off the builder package. Feel free to take over if you'd like.

@jasongrout jasongrout changed the title Split buildutils into buildutils and builter Split buildutils into buildutils and builder Aug 20, 2020
The new builder package is used to build extensions. buildutils now contains repo-specific utilities.

Fixes jupyterlab#8857
@github-actions github-actions bot added tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. tag:CSS For general CSS related issues and pecadilloes documentation tag:Examples labels Aug 20, 2020
@blink1073
Copy link
Member

Thanks, picking this up now

@blink1073
Copy link
Member

Usage will fail until we cut another release because @jupyterlab/builder is not in jupyterlab/staging/package.json dependencies.

@blink1073 blink1073 merged commit 5d06a5f into jupyterlab:master Aug 20, 2020
Extension System rework automation moved this from In progress to Done Aug 20, 2020
@blink1073
Copy link
Member

I released alpha 12

@jasongrout
Copy link
Contributor Author

Thanks!

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:CSS For general CSS related issues and pecadilloes tag:Design System CSS If a PR is editing any CSS files please add this tag for design team to review. tag:Examples
Projects
Development

Successfully merging this pull request may close these issues.

Separate out a new builder package
2 participants