New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull dynamic extension loading data from the webpack compilation #8913
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
@blink1073 - if we could get this into the beta, that would be great. |
I think with this change, we can cache things in the labextensions handler, i.e., delete this line: https://github.com/jupyterlab/jupyterlab_server/blob/0f8bb54c0badc6570ab2263c78fd1141dc316f9a/jupyterlab_server/handlers.py#L293 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just one question about the log output
] | ||
}) | ||
].concat(extras); | ||
|
||
const logPath = path.join(outputPath, 'build_log.json'); | ||
fs.writeFileSync(logPath, JSON.stringify(module.exports, null, ' ')); | ||
// const logPath = path.join(outputPath, 'build_log.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the log? I've used several times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll put in another PR that only saves it in development mode. Does that sound good to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. There is a conflict here, I'm afk for the next couple hours but I can rebase and release then.
Also, the default module ids in webpack 5 uses deterministic numbers in production mode, so we do not need the HashedModuleIdsPlugin anymore.
References
Fixes #8842
Code changes
Tweaked the webpack config several ways:
User-facing changes
Hopefully none
Backwards-incompatible changes