Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development mode to lab extension build scripts #8918

Merged
merged 9 commits into from Aug 27, 2020

Conversation

jasongrout
Copy link
Contributor

@jasongrout jasongrout commented Aug 27, 2020

References

This is built on #8913, so that should be merged first.

Code changes

This adds a development option to lab extension building scripts. The default is to build in production mode.

Also renames static_path option to static_url.

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jasongrout jasongrout added this to the 3.0 milestone Aug 27, 2020
@blink1073
Copy link
Member

Why not just merge this one since the rebase is done and build is in progress?

@blink1073
Copy link
Member

Ah, I see you already rebased

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073
Copy link
Member

I pushed fixes for examples and usage failures

@blink1073
Copy link
Member

browser_check is failing with a dynamic extension:

[W 2020-08-27 14:36:28.825 ServerApp] '_build'
...
[W 2020-08-27 14:36:40.742 ServerApp] 404 GET /foo/lab?token=fa278731aea392936cec7c943c946ab5600f2e988fab7c37 (::1) 34.89ms referer=None

I think there is a problem looking up the _build metadata.

@blink1073
Copy link
Member

The usage failure seems to have snuck in on #8913

@blink1073
Copy link
Member

blink1073 commented Aug 27, 2020

With 0e5be73 we get 404 GET /foo/lab/extensions/@jupyterlab/mock-extension/remoteEntry.js, which is expected until we make a release.

@jasongrout
Copy link
Contributor Author

Two other things when I did this. I'd love your thoughts:

  1. "static path" seems like a confusing name for an option, especially next to "core path". Really, it's a URL, most likely including the host, not a path on disk like the core path is.
  2. (an implementation detail...) - I think we should pass values from build-labextension into the webpack config using the webpack cli env feature, rather than relying on environment variables.

@blink1073
Copy link
Member

"static path" seems like a confusing name for an option, especially next to "core path". Really, it's a URL, most likely including the host, not a path on disk like the core path is.

Sure, static_url seems better, I'll update.

(an implementation detail...) - I think we should pass values from build-labextension into the webpack config using the webpack cli env feature, rather than relying on environment variables.

Makes sense to me.

@jasongrout
Copy link
Contributor Author

Thanks for the cleanups!

@blink1073 blink1073 merged commit 371789a into jupyterlab:master Aug 27, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants