Fix watch mode #9101
Merged
Fix watch mode #9101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `jupyter lab --dev-mode --watch`
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
Thanks Jason. Testing with the rc2, a third-party extension and the bundle approach way of developing extension, it looks like running: jlpm && jlpm run build
jupyter labextension install . --debug
jupyter lab --no-browser --watch
# in another terminal
jlpm run builddoesn't pick up the changes and emit the files (which it used to do with 2.x). Will open a new issue to track it. |
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
References
Fixes #9089
Code changes
User-facing changes
This fixes
jupyter lab --dev-mode --watchBackwards-incompatible changes