Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to webpack 5 #9148

Merged
merged 2 commits into from Oct 15, 2020
Merged

Upgrade to webpack 5 #9148

merged 2 commits into from Oct 15, 2020

Conversation

jasongrout
Copy link
Contributor

References

Code changes

Moved back to ^ instead of ~, similar to what we had for webpack 4.

User-facing changes

Backwards-incompatible changes

Moved back to ^ instead of ~, similar to what we had for webpack 4.
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member

jtpio commented Oct 12, 2020

From the release notes: https://webpack.js.org/blog/2020-10-10-webpack-5-release/#typescript-typings

It looks like we could also remove @types/webpack from:

"@types/webpack": "^4.41.0",

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit fb7b1e1 into jupyterlab:master Oct 15, 2020
Extension System rework automation moved this from In progress to Done Oct 15, 2020
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:services status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Examples
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants