Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install jupyter_packaging in tutorial #9190

Merged
merged 2 commits into from Oct 22, 2020
Merged

Install jupyter_packaging in tutorial #9190

merged 2 commits into from Oct 22, 2020

Conversation

jasongrout
Copy link
Contributor

References

Fixes #9174

Code changes

User-facing changes

Adds the step to install jupyter-packaging in the tutorial instructions

Backwards-incompatible changes

@jasongrout jasongrout added this to the 3.0 milestone Oct 21, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@ianhi
Copy link
Contributor

ianhi commented Oct 22, 2020

Maybe also in the guide for updating extensions? It seems you need both cookiecutter and jupyter_packaging to run the upgrade script

jtpio
jtpio approved these changes Oct 22, 2020
View changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 4d898e0 into jupyterlab:master Oct 22, 2020
1 check was pending
@jtpio jtpio mentioned this pull request Oct 22, 2020
Merged
@jtpio
Copy link
Member

jtpio commented Oct 22, 2020

Maybe also in the guide for updating extensions? It seems you need both cookiecutter and jupyter_packaging to run the upgrade script

Thanks @ianhi, sounds good 👍

Just opened #9199 if you want to have a look.

@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Apr 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Issues with 3.0.0-rc5 tutorial
3 participants
@jasongrout @ianhi @jtpio