Refuse to uninstall federated extensions. #9232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Since we did not install the federated extension, we should not be uninstalling it and deleting files from other packages and installation systems. Fixes jupyterlab#9230 See more discussion at jupyterlab#9231.
jasongrout
force-pushed
the
uninstall2
branch
from
cbe3882
to
e6ed7a5
Compare
Since federated extensions mask other extensions, we should error out right away if there is a federated extension. Otherwise, we might uninstall the hidden extension the federated extension is masking.
jasongrout
force-pushed
the
uninstall2
branch
from
6092ad5
to
82db529
Compare
|
This PR is included in #9244, so either we can merge this then that, or we can just close this as being superceded by that. |
This was referenced Oct 29, 2020
github-actions
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
References
Fixes #9230
See more discussion at #9231.
Code changes
Since we did not install the federated extension, we should not be uninstalling it and deleting files from other packages and installation systems.
User-facing changes
Users will need to uninstall federated extensions the same way they installed them.
Backwards-incompatible changes