Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme path in JupyterLab builder #9272

Merged
merged 2 commits into from Nov 4, 2020

Conversation

martinRenou
Copy link
Member

Signed-off-by: martinRenou martin.renou@gmail.com

References

Code changes

This fixes the path to the theme CSS in the config

User-facing changes

Backwards-incompatible changes

cc. @jtpio

Signed-off-by: martinRenou <martin.renou@gmail.com>
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member

jtpio commented Nov 3, 2020

Nice, thanks @martinRenou!

Something noticed when porting the theme cookiecutter to lab 3: jupyterlab/theme-cookiecutter#19

@jtpio jtpio added this to the 3.0 milestone Nov 3, 2020
builder/src/build.ts Outdated Show resolved Hide resolved
Co-authored-by: Jason Grout <jasongrout@users.noreply.github.com>
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit e550c12 into jupyterlab:master Nov 4, 2020
@martinRenou martinRenou deleted the fix_theme_path branch November 5, 2020 07:44
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 5, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants