Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable using federated extensions in dev mode when a flag is set. #9286

Merged
merged 2 commits into from Nov 6, 2020

Conversation

jasongrout
Copy link
Contributor

References

Fixes #9235

Code changes

User-facing changes

This is a much easier way to develop extensions against a development install of JupyterLab than the current add:sibling approach. While it may not work all the time, I think it will be helpful sufficiently often that we should make it possible.

Backwards-incompatible changes

This is a much easier way to develop extensions against a development install of JupyterLab than the current add:sibling approach. While it may not work all the time, I think it will be helpful sufficiently often that we should make it possible.

Fixes jupyterlab#9235
@jasongrout jasongrout added this to the 3.0 milestone Nov 5, 2020
@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member

jtpio commented Nov 5, 2020

Does that mean linking core packages with yarn as mentioned in #9235 (comment) is not necessary?

Or the federated extension should be built using the dev version of lab to properly populate the shared packages.

@jasongrout
Copy link
Contributor Author

Does that mean linking core packages with yarn as mentioned in #9235 (comment) is not necessary?

It depends. If no linking is done, the federated extensions will be built against existing package versions, but will use the dev versions at runtime. If the APIs change, that would be a problem. To fully test, you would indeed need to do some sort of linking so that typescript could do its compile-time checking properly.

Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jasongrout
Copy link
Contributor Author

I added some help text warning that federated extensions may not work in a dev install if they were compiled against published packages.

@jasongrout jasongrout merged commit 263634d into jupyterlab:master Nov 6, 2020
1 check was pending
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable dynamic?federated extensions in dev mode
3 participants