Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade script to use labextension for outputDir #9306

Merged
merged 2 commits into from Nov 10, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 9, 2020

References

Follow-up to jupyterlab/extension-cookiecutter-ts#109

At the moment, using the upgrade script would use static in the package.json, which causes the pip install -e . command to fail.

Code changes

User-facing changes

None

Backwards-incompatible changes

None

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

jupyterlab/upgrade_extension.py Outdated Show resolved Hide resolved
@jtpio jtpio added this to the 3.0 milestone Nov 9, 2020
@jasongrout
Copy link
Contributor

Thanks!

@jasongrout jasongrout merged commit d18704f into jupyterlab:master Nov 10, 2020
1 check was pending
@jtpio jtpio deleted the outputdir-labextension branch November 10, 2020 09:00
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants