Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate extension manager #9317

Merged
merged 1 commit into from Nov 12, 2020
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Nov 12, 2020

References

Follow-up to #9236 and #8804

Code changes

Addresses the following TODO:

// TODO: reinstate once we update the extension-manager
if (data.name === '@jupyterlab/extensionmanager') {
return;
}

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@jtpio
Copy link
Member Author

jtpio commented Nov 12, 2020

@jasongrout this would explain why @jupyterlab/extensionmanager was treated differently in the resolutions, as noticed yesterday.

@jasongrout
Copy link
Contributor

Yes, good catch. Thanks!

@jasongrout jasongrout merged commit 8074c2f into jupyterlab:master Nov 12, 2020
1 check passed
@jasongrout jasongrout added this to the 3.0 milestone Nov 12, 2020
@jtpio jtpio deleted the extensionmanager branch November 12, 2020 14:07
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants